Centralize all RBD related shell cmds and logging #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
=======================================
Coverage 28.53% 28.53%
=======================================
Files 34 34
Lines 1994 1994
=======================================
Hits 569 569
Misses 1364 1364
Partials 61 61Continue to review full report at Codecov.
|
Make sure that all calls made using rbd/rados binaries use a command method for execution, and that the related logging and error reporting is standardized.
codenrhoden
force-pushed
the
bugfix/ceph_cmd_stderr
branch
from
8733672 to
f492189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that all calls made using rbd/rados binaries use a command
method for execution, and that the related logging and error reporting
is standardized.
Generated new
rbd.testand ran suite. All tests pass (unless debugging is enabled, see #528).